[1.19] HTTPRoute delegation parentRefs fix #10763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issues linked to changelog: |
|
Visit the preview URL for this PR (updated for commit c9ce191): https://gloo-edge--pr10763-delegation-parentref-9x1wbqr1.web.app (expires Fri, 18 Apr 2025 18:17:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
|
ran into kubernetes-sigs/gateway-api#3708 flake |
davidjumani
approved these changes
Apr 11, 2025
shashankram
approved these changes
Apr 11, 2025
jenshu
added a commit
that referenced
this pull request
Apr 11, 2025
This was referenced Apr 11, 2025
ymesika
pushed a commit
that referenced
this pull request
Apr 23, 2025
Signed-off-by: timflannagan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we were not respecting the
parentRefsfield on child HTTPRoutes when parent matcher inheritance was enabled (via thedelegation.gateway.solo.io/inherit-parent-matcher: "true"annotation). This allowed any parent route to delegate to the child. This was fixed, and a new translator test case was added (which failed before the fix, and passes after the fix).Checklist: